Skip to content

Conversation

@tariq1890
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try not to deviate too much from the base we have in other repos

@elezar
Copy link
Member

elezar commented Apr 30, 2024

Thanks @tariq1890. I don't have strong opinions on check-vendor vs validate-modules, but do agree with @ArangoGutierrez that we should be consistent.

I'm happy to update our other projects to match this one if we feel that validate-modules is a better name for the target. I would like a separate vendor target though. Another subtlety is that it is ideal if the vendor target can be run in the development container to ensure that we don't modify the go.mod file based on the system go version.

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@tariq1890 tariq1890 merged commit c24715a into main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants